forked from lightningdevkit/ldk-node
-
Notifications
You must be signed in to change notification settings - Fork 1
fix: kotlin serialization version and jvm bindings #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyphillips
approved these changes
Jan 25, 2026
3b1dc8e to
c5f5e10
Compare
20faf67 to
5fa909a
Compare
Author
|
@ben-kaufman Tested serialization and jvm in bitkit-android, can be merged |
|
Should version be rc.16 or rc.17? I see last release says rc.17 |
ben-kaufman
approved these changes
Jan 26, 2026
Author
17, this was on top of the old one. Tested in android using 17 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade Kotlin and related dependencies to 2.x for compatibility with consuming apps. Add serialization support to JVM bindings for parity with Android.
Changes
JVM Bindings
uniffi-jvm.tomlwithgenerate_serializable_types = truegobley-uniffi-bindgenRelease